celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
554 stars 199 forks source link

eh/filters: send rpctransactions in pending-subscription #2252

Closed diwu1989 closed 6 months ago

diwu1989 commented 7 months ago

Porting https://github.com/ethereum/go-ethereum/pull/26126 to Celo so that the pending subscription TX has consistent JSON.

This was fixed upstream by always using the ethapi.NewRPCPendingTransaction function

codecov[bot] commented 6 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (f0adb14) 55.06% compared to head (985a4b2) 55.77%. Report is 4 commits behind head on master.

Files Patch % Lines
internal/ethapi/api.go 0.00% 8 Missing :warning:
accounts/abi/bind/backends/simulated.go 0.00% 4 Missing :warning:
eth/filters/api.go 0.00% 4 Missing :warning:
eth/tracers/api.go 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2252 +/- ## ========================================== + Coverage 55.06% 55.77% +0.71% ========================================== Files 684 684 Lines 114596 91952 -22644 ========================================== - Hits 63097 51287 -11810 + Misses 47617 36783 -10834 Partials 3882 3882 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

palango commented 6 months ago

@diwu1989 Thanks for the PR, I added another comment cleaning up some unnecessary parameter.

github-actions[bot] commented 6 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 50682652a7d6dc7a915d7d83ae8a16c0c18375b7

coverage: 49.9% of statements across all listed packages
coverage:  63.4% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.8% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.6% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 6 months ago
5891 passed, 45 skipped