celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
554 stars 199 forks source link

eth/tracers: add `txHash` field on txTraceResult #2254

Closed carterqw2 closed 6 months ago

carterqw2 commented 6 months ago

Description

This PR modifies the interface for the results of debug_traceBlock and debug_traceCall by adding the txHash, allowing users to identify which transaction's trace result corresponds to.

Cherry picked https://github.com/ethereum/go-ethereum/pull/27183 to make block tracing work (see details here).

Other changes

No.

Tested

Updated unit test.

Related issues

github-actions[bot] commented 6 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 1fc34733020cef6666d46ac67c86bfe6e1df2b40

coverage: 50.1% of statements across all listed packages
coverage:  63.4% of statements in consensus/istanbul
coverage:  43.3% of statements in consensus/istanbul/announce
coverage:  55.9% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 6 months ago
5891 passed, 45 skipped