search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

HFork flags and configs #2265

Closed hbandura closed 7 months ago

hbandura commented 7 months ago

Adds the override flags, configs, and necessary boilerplate for the H fork activation, while removing the old Gingerbread overrides.

github-actions[bot] commented 7 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit b76b1267289d67b464c6236dc220ab6e47e1f3f6

coverage: 50.0% of statements across all listed packages 
coverage:  63.4% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.9% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  62.0% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 7 months ago
5891 passed, 45 skipped
piersy commented 7 months ago

Hi @hbandura what's the plan for the H hardfork, I'm not aware of any changes agreed yet? Also do we want to call it just 'H'? It seems historically we went for a more memorable name such as donut, espresso ...

hbandura commented 7 months ago

Hi @hbandura what's the plan for the H hardfork, I'm not aware of any changes agreed yet? Also do we want to call it just 'H'? It seems historically we went for a more memorable name such as donut, espresso ...

In the past we have gone with Xfork when the name hasn't been defined yet. It can be renamed afterwards, it usually takes some time for the name to be discussed and decided.

While it hasn't been yet approved, there's a change to be written and tested for a possible future fork. I'll continue this in private.