search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
552 stars 196 forks source link

Improve error messages for credit/debit reverts #2270

Closed karlb closed 4 months ago

karlb commented 4 months ago

Description

The revert messages now show up in the RPC responses (for calls). For most cases, this should provide enough debugging information without looking at the server logs.

Tested

Tested both cases manually by creating a fee currency that always fails in the respective method and sending a CIP-64 calls and txs via viem.

Backwards compatibility

Fully backwards compatible

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.76%. Comparing base (f0adb14) to head (3e875b1). Report is 13 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2270 +/- ## ========================================== + Coverage 55.06% 55.76% +0.70% ========================================== Files 684 684 Lines 114596 91961 -22635 ========================================== - Hits 63097 51282 -11815 + Misses 47617 36782 -10835 - Partials 3882 3897 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karlb commented 4 months ago

Accidentally pushed to my fork of this repo, which prevents the CI from succeeding. Replacement PR: https://github.com/celo-org/celo-blockchain/pull/2271