search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

H fork implementation #2278

Closed hbandura closed 6 months ago

hbandura commented 7 months ago

-H fork activation and flags -Celo denominated txs

github-actions[bot] commented 7 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 272982b71940dae0072523bc69b195620590f841

coverage: 46.9% of statements across all listed packages 
coverage:  57.2% of statements in consensus/istanbul
coverage:  23.7% of statements in consensus/istanbul/announce
coverage:  54.3% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  65.0% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 7 months ago
5882 passed, 45 skipped
karlb commented 6 months ago

Looks good to me now except for the last missing MaxFeeInFeeCurrency as mentioned by @carterqw2.

We'll need tests, but since this PR is already taking a while, I prefer to have them in a separate PR in this case.

karlb commented 6 months ago

This has been merged into master, not our current default branch (celo4). hbandura Can you take care of merging this into celo4?

EDIT: sorry, repo confusion. Please ignore!