search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

fix(eth/tracers): wrong balance on prestate tracer #2290

Closed chuwt closed 6 months ago

chuwt commented 6 months ago

Description

Fix the wrong balance on prestate_tracer.js

go-ethereum fix: prestate_tracer

palango commented 6 months ago

Hi @chuwt ,

thank you for opening this PR. The upstream fix that solves this problem seems to be https://github.com/ethereum/go-ethereum/commit/0f4942214d76385c52c7917212331c9bad8b3566, which includes more changes. Are those required for our codebase as well?

It would also be nice if you could add a test to see that the behaviour now matches the expectation.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.80%. Comparing base (f0adb14) to head (2afcccb). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2290 +/- ## ========================================== + Coverage 55.06% 55.80% +0.74% ========================================== Files 684 684 Lines 114596 91979 -22617 ========================================== - Hits 63097 51326 -11771 + Misses 47617 36759 -10858 - Partials 3882 3894 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chuwt commented 6 months ago

Hi @palango, there are too many discrepancies in the trace section. I will close this PR and then prepare a new one specifically for the trace part.