search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Remove exchange rate calculation for non CELO denominated txs in state_transition #2299

Closed hbandura closed 4 months ago

hbandura commented 5 months ago

Fix state_transition producing invalid gas used values for pre-H fork transactions by preventing from taking the exchange rate of fee currencies meant for only CELO denominated txs.

Rename some variables to be more specific about them applying only to this tx type.

github-actions[bot] commented 5 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 06eee2c5784b57105ae10c384d8a52a553a7aa12

coverage: 51.2% of statements across all listed packages 
coverage:  63.6% of statements in consensus/istanbul
coverage:  43.2% of statements in consensus/istanbul/announce
coverage:  56.0% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  65.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 5 months ago
5887 passed, 45 skipped
hbandura commented 5 months ago

A full sync is currently running, may take a few days. When it finishes we can merge this