search

celo-org / celo-blockchain

Official repository for the golang Celo Blockchain
https://celo.org
GNU Lesser General Public License v3.0
560 stars 198 forks source link

Fix effective gas price calculation #2303

Closed karlb closed 5 months ago

karlb commented 5 months ago

6351612d67d4cf5e18708a0536f0cb43afa19e43 introduced the bug by accidentally losing the negation in if !s.b.ChainConfig().IsLondon(bigblock). This results in wrong effectiveGasPrice values to be returned from the RPC. The actually transferred fees are correct.

github-actions[bot] commented 5 months ago

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 8943a5def6aa9e489ff6c4e417092aae752ea28a

coverage: 50.9% of statements across all listed packages 
coverage:  63.4% of statements in consensus/istanbul
coverage:  42.8% of statements in consensus/istanbul/announce
coverage:  55.8% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  65.5% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random
github-actions[bot] commented 5 months ago
5883 passed, 45 skipped