search

celo-org / celo-bls-snark-rs

Implements SNARK-friendly BLS signatures
https://celo.org
Apache License 2.0
84 stars 21 forks source link

deps: fake the old bench-utils structure to avoid pulling in ark-std 0.3.0 #230

Open gtank opened 2 years ago

gtank commented 2 years ago

When I followed the upstream refactoring earlier, it induced a dependency on the newer ark-std, causing our downstream code (like the Plumo prover) to transitively depend on it as well.

Tested

Builds, tests pass, and there is no ark 0.3.x in the dependency tree anymore.

Related issues

This is part of the fix for the plumo prover build https://github.com/gtank/plumo-prover/commit/a8abea11bea6e43824ed6c74e89575b33baab9f5

gtank commented 2 years ago

Followup thought: should we specify revs for each of the old ark dependencies or continue to rely on the lockfile?

edit: probably these versions https://github.com/celo-org/celo-bls-snark-rs/pull/226

edit 2: this won't fix the problem https://github.com/celo-org/celo-bls-snark-rs/pull/231#issuecomment-1006018031