search

celo-org / celo-composer

celo-composer is a starter project with all code needed to build, deploy, and upgrade a dapps on Celo.
MIT License
113 stars 104 forks source link

feat: `celo-composer` `v.1.0.14` #283

Closed therealharpaljadeja closed 3 months ago

therealharpaljadeja commented 3 months ago

Celo Composer support for latest viem and wagmi libraries

@viral-sangani @GigaHierz Test thoroughly!

Hackers can now build with Metamask on their pc and then later demo it in Site tester.

netlify[bot] commented 3 months ago

Deploy Preview for celo-composer ready!

Name Link
Latest commit e62e04ce4b471cfdd63a3cd47793c5fcc1811b0a
Latest deploy log https://app.netlify.com/sites/celo-composer/deploys/65fdd91b9c9b400008f6d472
Deploy Preview https://deploy-preview-283--celo-composer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/runtime@7.24.1 None 0 262 kB nicolo-ribaudo
npm/@emotion/hash@0.9.1 environment 0 10.2 kB emotion-release-bot
npm/@emotion/serialize@1.1.3 environment +2 83.9 kB emotion-release-bot
npm/@ethereumjs/tx@4.2.0 None +1 574 kB holgerd77
npm/@metamask/utils@5.0.2 None +3 438 kB metamaskbot
npm/@rainbow-me/rainbowkit@2.0.2 Transitive: environment +17 3.71 MB danielsinclair
npm/@tanstack/react-query@5.28.6 environment +1 3.79 MB tannerlinsley
npm/@wagmi/connectors@4.1.18 Transitive: environment, eval, filesystem, network, shell, unsafe +221 226 MB awkweb
npm/eciesjs@0.3.18 None +3 2.57 MB kigawas
npm/eventemitter2@6.4.9 None 0 81.3 kB rangermauve
npm/eventemitter3@5.0.1 None 0 73.4 kB lpinca
npm/napi-wasm@1.1.0 None 0 86.2 kB devongovett
npm/regenerator-runtime@0.14.1 None 0 27.9 kB benjamn
npm/wagmi@2.5.12 Transitive: environment, network +12 8.18 MB awkweb

🚮 Removed packages: npm/@babel/runtime@7.21.5, npm/@celo/rainbowkit-celo@1.1.1, npm/@ledgerhq/connect-kit-loader@1.1.8, npm/@rainbow-me/rainbowkit@1.0.3, npm/@wagmi/chains@1.3.0, npm/@wagmi/connectors@3.1.11, npm/@wagmi/core@1.2.2, npm/clsx@1.1.1, npm/preact@10.14.1, npm/resolve@1.22.2, npm/viem@0.3.30, npm/wagmi@1.4.13

View full report↗︎

socket-security[bot] commented 3 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Native code npm/secp256k1@5.0.0
Native code npm/utf-8-validate@6.0.3

View full report↗︎

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/secp256k1@5.0.0
  • @SocketSecurity ignore npm/utf-8-validate@6.0.3
GigaHierz commented 3 months ago

okay, so we are not using wallet connect here right? it's not shown to me in the options.

image
therealharpaljadeja commented 3 months ago

okay, so we are not using wallet connect here right? it's not shown to me in the options.

image

Yeah at hackathons, people use browser-based wallets. Also, Walletconnect shows a ton of wallet options which may not support Celo and if someone tries that wallet, unexpected errors can pop up...

viral-sangani commented 3 months ago

Tried and tested in -

LGTM