celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
697 stars 370 forks source link

dappkit deprecation #10207

Closed nicolasbrugneaux closed 1 year ago

nicolasbrugneaux commented 1 year ago

Following this convo:

Hello there, the topic of "moving the core-contract types so they can more easily be imported in typescript" has come up again during the apptooling meeting and we're gonna try to separate into their own package. The only question is whether to move them to a different package or even outside of the monorepo.

The current trend seems to be to cleanup the monorepo a bit, but having the types stay here actually makes tons of sense (no tooling to reinvent, no submodules to handle)

Any thoughts?

nicolasbrugneaux commented 1 year ago

Tagging @celo-org/default-owners

arthurgousset commented 1 year ago

Reflecting discussion from weekly sync:

Note:

nicolasbrugneaux commented 1 year ago

WIP findings https://www.notion.so/clabsco/WIP-celo-contractkit-830cce5acffe4d65bbe9a61724364f63, I will keep updating that doc as I gather more info

nicolasbrugneaux commented 1 year ago

Scheduled a call with Valora which seems to be the only users of dappkit to talk about sunsetting

nicolasbrugneaux commented 1 year ago

Dappkit sunsetting post https://forum.celo.org/t/sunsetting-dappkit/5336

nicolasbrugneaux commented 1 year ago

Contractkit public sunsetting post https://forum.celo.org/t/sunsetting-contractkit/5337

nicolasbrugneaux commented 1 year ago

Todo following the two blog posts:

Context:

arthurgousset commented 1 year ago
nicolasbrugneaux commented 1 year ago

Migration guide

Removal of dappkit

nicolasbrugneaux commented 1 year ago

Closing this and following issue specific to contractkit can be found here: https://github.com/celo-org/celo-monorepo/issues/10289