search

celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
695 stars 369 forks source link

Upgrade Ledger Signer to be able to sign tx besides celo legacy #10487

Open aaronmgdr opened 1 year ago

aaronmgdr commented 1 year ago

Expected Behavior

can sig eip1559 and the new celo tx with feecurrecy but no gatewayfee

Current Behavior

only signs celo legacy transactions

aaronmgdr commented 1 year ago

needs someone smarter than me

aaronmgdr commented 1 year ago

@0xarthurxyz can you help figure out who has the knowledge of C and crypto needed to implement this? / who will own?

arthurgousset commented 1 year ago

Thanks for logging this here @aaronmgdr! Brief note for future reference that @timmoreton kindly assigned @kobigurk and took ownership to ping him on TG.

arthurgousset commented 7 months ago

Asked for an owner (re point of contact with Kobi) on Slack.

aaronmgdr commented 6 months ago

from @marekolszewski

On the topic of ledger support, @ericnakagawa is working with a dev shop called Blooo right now to add support for newer transaction types to our ledger app. I would check in with him to confirm that Blooo is not adding anything that might be deprecated soon.

https://clabsco.slack.com/archives/C014SRL4URY/p1709335978942099?thread_ts=1709302433.634719&cid=C014SRL4URY