search

celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
687 stars 362 forks source link

Add integration tests for Anvil migrations #10999

Closed arthurgousset closed 1 month ago

arthurgousset commented 2 months ago

The current migration script that generates the Anvil devchain has no tests. Effectively, the devchain is generated and not tested.

DevTooling wants to start using the Anvil devchain for its test suite and CI, so we need to assert the devchain is setup correctly. For example:

The goal is to add automated tests that assert the devchain has been generated correctly.

The Anvil migration script deployed and configures a long list of contracts, each of which probably needs to be tested somehow. On the other hand, we have existing Foundry tests.

arthurgousset commented 2 months ago

Started working on this today

Edit: I didn't work on this yet, instead we agreed to prioritise this last week:

arthurgousset commented 1 month ago

I'm starting work on this today.

lvpeschke commented 1 month ago

Weekly commitment check-in: @arthurgousset can you provide a status update?

arthurgousset commented 1 month ago

This issue is closed by this PR:

The PR is functionally complete and ready for review. The reason it's blocked is an unrelated failing test on CI that I'm debugging. Including PR review, I expect this issue to be closed tomorrow Tue, Jun 4.

The progress on this issue is in line with the estimated timeline. The estimated completion was set at Tue, Jun 4.

I'll start working on my new weekly commitment tomorrow as estimated in that issue: