Closed arthurgousset closed 3 months ago
Follow-on task from this PR:
I decided to keep that PR small, but in a subsequent PR, I'd like to refactor the test-sol/ directory structure like:
test-sol/
test-sol/unit/ test-sol/e2e/ test-sol/integration/
That way we could run tests on CI with a command structure like:
# unit tests forge test --match-path "*test-sol/unit/*" # e2e tests forge test --match-path "*test-sol/e2e/*" # integration tests forge test --match-path "*test-sol/integration/*"
Consider refactoring this step on CI:
https://github.com/celo-org/celo-monorepo/blob/bfbad45621bd5d5ac5cb35de1b005ef126c6b996/.github/workflows/protocol_tests.yml#L102-L104
Move anvil scripts to scripts/anvil/ instead of migrations_sol/ (we already have scripts/truffle/ and scripts/bash/)
scripts/anvil/
migrations_sol/
scripts/truffle/
scripts/bash/
Organise CI workflow into unit, integration, and e2e tests
https://github.com/celo-org/celo-monorepo/blob/bfbad45621bd5d5ac5cb35de1b005ef126c6b996/.github/workflows/protocol_tests.yml#L64-L65
- name: Run tests common + name: Run unit tests common
Follow-on task from this PR:
I decided to keep that PR small, but in a subsequent PR, I'd like to refactor the
test-sol/
directory structure like:That way we could run tests on CI with a command structure like:
Nice to haves
Consider refactoring this step on CI:
https://github.com/celo-org/celo-monorepo/blob/bfbad45621bd5d5ac5cb35de1b005ef126c6b996/.github/workflows/protocol_tests.yml#L102-L104
Move anvil scripts to
scripts/anvil/
instead ofmigrations_sol/
(we already havescripts/truffle/
andscripts/bash/
)Organise CI workflow into unit, integration, and e2e tests
https://github.com/celo-org/celo-monorepo/blob/bfbad45621bd5d5ac5cb35de1b005ef126c6b996/.github/workflows/protocol_tests.yml#L64-L65