celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
684 stars 360 forks source link

`forge test` should be all green and exclude e2e tests that require a devchain #11106

Open arthurgousset opened 2 days ago

arthurgousset commented 2 days ago

Expected Behavior

When forge test is run in the protocol/ package, all tests should pass.

Current Behaviorf

When forge test is run in the protocol/ package, it is currently expected that 3 tests are failing (the E2EDemo & 2 RegistryIntegrationTest). That's these tests require a devchain to be serving at localhost to pass.

This is confusing for new-joiners, because expecting tests to fail is not natural.