search

celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
684 stars 360 forks source link

Wallet should calculate tobin tax for gold exchanges #1249

Closed jmrossy closed 4 years ago

jmrossy commented 4 years ago

Expected Behavior

The contract should be queried to get the actual fee

Current Behavior

The UI is all done for #955 but the fee is hardcoded

annakaz commented 4 years ago

Will want to call computeTobinTax() on Reserve contract

annakaz commented 4 years ago

Blocked on this until a new network is deployed with an updated Reserve contract

Edit: can actually use .call() to avoid sending a transaction but get the updated fee

annakaz commented 4 years ago

We will either have to start using contractkit, or update the deprecated walletkit to interact with the Reserve contract

jmrossy commented 4 years ago

Or just hack in the Reserve contract manually into the wallet, though I don't recommend that. I'd prefer to use contract kit but realistically we may just have to update wallet kit for now. @annakaz WDYT?

annakaz commented 4 years ago

Good point- we can use contractkit to expose the raw contract, then manually call it from there