celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
684 stars 360 forks source link

Monorepo SBAT publish npm packages without posinstall problems #381

Closed mcortesi closed 4 years ago

mcortesi commented 4 years ago

Expected Behavior

We are currently misusing posinstall script. It should be used to install depencies or patch them, and nothing more.

To build the monorepo, we need a build npm script.

Currently we use postinstall for:

This issue should remove the 'not ok' usage, and move it to a yarn build stage.

Current Behavior

mcortesi commented 4 years ago

This was done already