celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
699 stars 369 forks source link

Transaction should not be added to the feed if user does not enter pin #4891

Closed Lss-Ankit closed 4 years ago

Lss-Ankit commented 4 years ago

Frequency: 100% Repro App version: Test Flight build Valora app build v1.0.0 (17) , Android Valora Mainnet build v1.0.0 (16) Repro on device: iPhone 7+ (13.3.1), Google Pixel Xl (8.1) Test Account: Backup Key: (757) 699-9899. Repro Steps:

  1. Launch the Application and signin with test account
  2. Tap on Send button.
  3. Select any valora contact user.
  4. Enter amount and tap on Review button
  5. Tap on Send button.
  6. Tap on < arrow from Enter PIN screen.
  7. Observe.

Current Behavior: “Confirming…” text is shown continuously for transaction Expected Behavior: Transaction activity should not be shown. Investigation: Transaction activity with confirming text disappeared after cold launching the app. Impact: Users may get confused / frustrated by seeing transaction activity with Confirming text. Attachment: Confirmissue.mp4 (Bug observe at 18 sec)

Lss-Ankit commented 4 years ago

Hi @tarikbellamine I have verified this issue using latest Android internal build v1.3.0(1004294316) and found issue is fixed. User redirect to send page when tapping on < button on enter Pin page Repro on devices: Vivo V11 pro (10),iPhone 6+ (12.4.5)