celo-org / celo-monorepo

Official repository for core projects comprising the Celo platform
https://celo.org
Apache License 2.0
684 stars 360 forks source link

cEUR support for CLI #6793

Closed aslawson closed 3 years ago

aslawson commented 3 years ago

CLI use cases that need updating

Detailed breakdown:

clrblmt commented 3 years ago

Added details to requirements

asaj commented 3 years ago

Check no cEUR balance before destroying ReleaseGold contracts celocli releasegold:refund-and-finalize

Is this needed? IIUC this was to prevent contracts from being destroyed that may have accumulated cUSD validator rewards

asaj commented 3 years ago

What about account:balance?

aslawson commented 3 years ago

seems like economics team has taken most of this on, but not done in a generic stabletoken fashion. will create a separate ticket to generalize it.

@gastonponti will scope remaining work needed

martinvol commented 3 years ago

It is included on the ticket, but here's an example of how the cli handles oracle:list for an stableToken today

./packages/cli/bin/run oracle:list 0xcCA78ae41fe8F83eE7F37B0110eb6FAe3E9Ca0F0
(node:3956) ExperimentalWarning: The fs.promises API is experimental
Failed to close the connection: Error: Expected 0xcCA78ae41fe8F83eE7F37B0110eb6FAe3E9Ca0F0 to be one of: StableToken
See more help with --help
 ›   Error: Expected 0xcCA78ae41fe8F83eE7F37B0110eb6FAe3E9Ca0F0 to be one of: StableToken
 ›   See more help with --help
martinvol commented 3 years ago

We should also update these commands:

  1. celocli network:contracts
  2. celocli network:parameters
barbaraliau commented 3 years ago

@gastonponti is this item in the description complete? Check no cEUR balance before destroying ReleaseGold contracts celocli releasegold:refund-and-finalize

aslawson commented 3 years ago

Removed https://app.zenhub.com/workspaces/cap-backlog-board-600598462807be0011921c65/issues/celo-org/celo-monorepo/7157 from this epic as it is low priority and closing Epic as complete.