celo-org / developer-tooling

🛠️ SDKs and CLI for interacting with Celo
Apache License 2.0
10 stars 6 forks source link

CLI should let approve proposals when in execution stage #177

Closed martinvol closed 1 month ago

martinvol commented 6 months ago

Package

@celo/celocli

Have you ensured that all of these are up to date?

What version of the package are you on?

4

What command or function is the bug in?

celocli governance:approve

Operating System

None

Describe the bug

Previously, proposals where only approvable when they where in the approving stage. Nowadays, the approval stage doesn't exist anymore and rather they can be approved in both referendum and execution (source). But the cli only lets approve when in referendum stage (source).

arthurgousset commented 5 months ago

Great point, thanks for logging this @martinvol 👍

aaronmgdr commented 1 month ago

being done in #296