search

celo-org / developer-tooling

🛠️ SDKs and CLI for interacting with Celo
Apache License 2.0
10 stars 6 forks source link

Enable codecov in celo-org/developer-tooling #212

Closed arthurgousset closed 5 months ago

arthurgousset commented 5 months ago

Enable codecov for celo-org/developer-tooling so that we can:

  1. track how much coverage we have across the repo
  2. track how future PRs change code coverage
arthurgousset commented 5 months ago

I found instructions to get started here: https://app.codecov.io/gh/celo-org/developer-tooling/new

I'd need the help of someone with GitHub admin permissions to set a secret in the repository.

arthurgousset commented 5 months ago

Asked in #eng-permissions

arthurgousset commented 5 months ago

From @alvarof2:

Added the CODECOV_TOKEN to Akeyless with the necessary perms, opened a PR with a usage example:

Workflow works but cannot find any coverage file to upload :disappointed: Would need some input about how/where these are generated in the repo to tune it further _:pray:

alvarof2 commented 5 months ago

👋 Hi @arthurgousset !

After some fighting, managed to integrate Codecov to general_test job in Build & Test GH Action (PR #211). There are other jobs in the workflow for other tests, like wallet-test or contractkit-tests, but unsure if it should be integrated there also. In that case, I would suggest getting the token in 1 job and sharing it for others, but I leave that kind of decisions to the team :).

arthurgousset commented 5 months ago

@shazarre kindly agreed to take over from here and enable code coverage on the missing packages.

Check out the convo in this PR for more context:

shazarre commented 5 months ago

Closing as done in the PR - including all the missing packages.