search

celo-org / developer-tooling

🛠️ SDKs and CLI for interacting with Celo
Apache License 2.0
10 stars 6 forks source link

personal_* methods are deprecated / sunset rpcwallet? #257

Closed aaronmgdr closed 1 month ago

aaronmgdr commented 4 months ago

while moving wallet-rpc tests from ganache to anvil i discovered that the personalimportkey method returns an method not found error. it turns out the personal* methods are all deprecated in geth and not implimented in anvil

As OP geth mirrors geth closely its safe to assume these will not work on Cel2 either.

As the RPCWallet at its core depends on calling these personal methods to initialize, setup accounts, and sign transactions, It seems it would be time to submit it for sunset.

For alternative see https://geth.ethereum.org/docs/tools/clef/introduction

shazarre commented 2 months ago

the namespace is also used in releasecelo/admin-revoke celocli command https://github.com/celo-org/developer-tooling/blob/master/packages/cli/src/commands/releasecelo/admin-revoke.ts