celo-org / developer-tooling

🛠️ SDKs and CLI for interacting with Celo
Apache License 2.0
10 stars 6 forks source link

celocli + ledger + cusd transfer fails #353

Open aaronmgdr opened 1 week ago

aaronmgdr commented 1 week ago

Package

@celo/celocli

Have you ensured that all of these are up to date?

What version of the package are you on?

5.2.1

What command or function is the bug in?

transfer:dollars --useLedger

Operating System

None

Describe the bug

so as an example: 'celocli transfer:celo' works fine with --useLedger, but 'celocl transfer:dollars' doesn't work

Error: ledger-signer@signTransaction: Incorrect Data. Verify that the feeCurrency is a valid one

note re reported by zviad via discord

aaronmgdr commented 1 week ago

seems the issue is celo ledger spender on live is still on the previous version

aaronmgdr commented 6 days ago

when we talk with ledger team. we should ask about this

aaronmgdr commented 2 days ago

related issue https://github.com/celo-org/developer-tooling/issues/394

aaronmgdr commented 2 days ago
 haven't heard back from Zviad yet but I just tried a cUSD transfer from a ledger using both celo terminal and celocli and both fail:

$ celocli transfer:dollars --from 0x000...000 --to 0x000...000 --value X --useLedger --ledgerAddresses=1 (node:31653) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead. (Use node --trace-deprecation ... to show where the warning was created) Retrieving derivation Paths [ 0, 1, 2, 3, 4, 5, 6 ] Running Checks: :heavy_check_mark: Account has at least X cUSD :heavy_check_mark: Compliant Address :heavy_check_mark: Compliant Address :heavy_check_mark: Account can afford transfer in cUSD and gas paid in CELO All checks passed Upgrade your celo ledger app to at least 1.2.0 before cel2 transition automatically converting to legacy transaction Sending Transaction: transfer... failed: ledger-signer@signTransaction: Incorrect Data. Verify that the feeCurrency is a valid one

Received an error during command execution, if you believe this is a bug you can create an issue here:

https://github.com/celo-org/developer-tooling/issues/new?assignees=&labels=bug+report&projects=&template=BUG-FORM.yml

Error: ledger-signer@signTransaction: Incorrect Data. Verify that the feeCurrency is a valid one at LedgerSigner. (/Users/user/.nvm/versions/node/v22.3.0/lib/node_modules/@celo/celocli/node_modules/@celo/wallet-ledger/lib/ledger-signer.js:90:31) at Generator.throw () at rejected (/Users/user/.nvm/versions/node/v22.3.0/lib/node_modules/@celo/celocli/node_modules/@celo/wallet-ledger/lib/ledger-signer.js:29:65) Error: ledger-signer@signTransaction: Incorrect Data. Verify that the feeCurrency is a valid one