Open aaronmgdr opened 8 months ago
this is a mega big upgrade
reading over the upgrade guide and guide to create transaction plugins for web3 v4. i think the signing that happens in wallet-base would become a web3 plugin @celo/web3-plugin-gas-tokens if wallet-base was the only wallet-*** package i would say thats all there was to it however...
the celo/wallet- system of packages is a bit hard to move as it doesnt really correspond as far as i see with uses of the term wallet in web3 (or ethers or viem) they are kinds like signers in the sense that the signTransaction is in them. maybe they can go away? but will need to make sure hsm signers and ledger signing and all that still work. which will be tricky to test
potentially blocked by #220
although we could possibly get around it by
pausing for now
obvious move is to web3 v1. however given the complexity at this point its likely not more difficult to move to contractkit / cli being powered by viem,
Currently on web3 1.10.3 (final version for 1.x) we need to move away for security
There are api changes which nessessaitate some design thinking on how we re build on top of the new version
https://docs.web3js.org/guides/web3_upgrade_guide/x/