search

celo-org / governance

Governance Repository for Celo
Apache License 2.0
46 stars 68 forks source link

Proposal-Cleanup #211

Closed Khadeeejah closed 1 year ago

Khadeeejah commented 1 year ago

Hi, I noticed some
tag showing after merging and i also mistakenly pushed a duplicate of a table, during conflict resolution.

Thanks

Khadeeejah commented 1 year ago

LGTM. Please note that the payload json for this proposal will not result in the intended execution outcome.

The JSON executes the approval method on the stableToken contract with the governance contract as the holder and the DAO address as the spender. The governance contract has no cUSD stored in it at present. You can view the token balances here

The governance proposal should use either specify GoldToken or StableTokenEUR as these are the only two tokens that have sufficient balance to meet the proposal specifications.

Hi @0xzoz thank you for this feedback, i have updated the payload json from StableToken to GoldToken in my next pr. LMK what you think. cheers.