Plan CIP-64 to CIP-66 switch

celo-org / op-geth

GNU Lesser General Public License v3.0

0 stars 0 forks source link

Plan CIP-64 to CIP-66 switch #112

Open karlb opened 6 months ago

karlb commented 6 months ago

[ ] At which time will CIP-66 support be included in the blockchain?
[ ] When will client libraries start using CIP-66? How do they know when it is supported by the blockchain client?
[ ] We will have to whitelist both the FeeCurrencyAdapter deployments (to support CIP-64) and the real token (for CIP-66). Do we want to take additional measure to avoid accidentally using the wrong one when both are whitelisted?

aaronmgdr commented 5 months ago

ah i have been assuming that 66 will be supported from day 1 on cel2. if not we need to re do how we are implementing rpc caller libraries

karlb commented 4 months ago

The basic plan is:

Add support for CIP-66 without changing the FeeCurrencyDirectory . Both CIP-64 and CIP-66 txs will use the adapters. Libraries can start enabling CIP-66 txs now.
Remove support for CIP-64. Now everyone will use CIP-66 txs with the adapters.
Add non-adapted tokens to the FeeCurrencyDirectory. The real tokens can be safely used because CIP-64 is not supported anymore. Listing all entries might be a bit confusing at this stage, since two entries for the same token are present in some cases (the adapter and the token itself).
Remove adapters from FeeCurrencyDirectory .

karlb commented 3 months ago

When will client libraries start using CIP-66? How do they know when it is supported by the blockchain client?

Suggestion: client libraries will default to CIP-64 for now and provide a way to explicitly request CIP-66 txs. Once CIP-66 is available on all Celo networks, new releases of client libraries will default to using CIP-66.

Does that sound good @aaronmgdr?

aaronmgdr commented 3 months ago

to be honest because of the new field im not sure if we will be able to get all libraries to default to 66. specifically viem. because while they do have a custom fees modules, it only is for calculating maxFeePerGas maxPriorityFeePerGas. they would need the function to be allowed to return arbitrary fields / data which they might do but you know...

karlb commented 3 months ago

That's a good point. Then let's only settle on the "client libraries will default to CIP-64 for now and provide a way to explicitly request CIP-66 txs." part now and investigate the other questions later as part of this issue.