search

celo-org / op-geth

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Fix "feeCurrency" included in non-Celo marshalled tx JSON #121

Closed ezdac closed 1 month ago

ezdac commented 1 month ago

Closes #117

Originally I thought that changing the FeeCurrency omitempty marshalling-behavior depending on the tx-type (Celo / non-celo txs) would be more significant code changes (see https://github.com/celo-org/op-geth/issues/117#issuecomment-2098013535).

Thanks to struct-embedding this does not seem to be the case.

ezdac commented 1 month ago

@piersy could you give this a quick look, since you worked on #115 and there is potential overlap