Handle migrated celo transactions

piersy commented 2 weeks ago

Introduces support for encoding/decoding legacy celo transaction types.

That covers:

Type 0 - The legacy transaction has been updated and now has the celo specific fields added
Type 124 - The v1 of the dynamic fee tx.

Additionally the transaction code has been updated to be less invasive to the op-geth repo by moving celo code into celo specific files and by removing celo specific methods added to the TxData interface.

Additionally I reversed the EthCompatible boolean field since it's used to determine how to encode a legacy tx, and if unset (I.E. EthCompatible == false) then the legacy tx would be encoded as a celo legacy tx, which of course broke a lot of tests. So now the field is called CeloLegacy and if unset the tx will be encoded as an eth compatible transaction.

palango commented 2 weeks ago

Oh, and please create a follow-up issue to add some tests.

piersy commented 2 weeks ago

Oh, and please create a follow-up issue to add some tests.

Added issue here - https://github.com/celo-org/op-geth/issues/151

celo-org / op-geth

Handle migrated celo transactions #150