search

celo-org / op-geth

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Enabling Cel2 does not need special base fee case #239

Closed karlb closed 2 months ago

karlb commented 2 months ago

We can just continue calculating base fees with the normal EIP-1559 formula. There is not need to special case this block. Without the special case, we also don't need the test for the special case.

Removing the special case makes it easier to enable Cel2 in other tests without breaking the tests by unintentionally modifying the base fee.

This change might require a corresponding change in our migration script for consistency.

piersy commented 2 months ago

Don't totally get why we need the gingerbread check here. In Celo1 we needed that check to understand when to retrieve the initial from the contract that was keeping track of the gasPriceMinimum. In this scenario where we have the baseFee field from the beginning, I think that this check it's not entirely necessary, we kind of start being gingerbread

But other than that, looks good to me

@gastonponti I added a comment that might help explain - https://github.com/celo-org/op-geth/pull/239#discussion_r1775130189