search

celo-org / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
3 stars 2 forks source link

Preview of celo4 branch (do not merge) #100

Closed karlb closed 4 months ago

karlb commented 5 months ago

I have done a few changes to the code during the rebase to make it work. Please have a look at the comments I created and the following commits:

The rest should just be merging, squashing and minor cleanups.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.40%. Comparing base (1d5a982) to head (063933d). Report is 4666 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #100 +/- ## ============================================ - Coverage 64.18% 25.40% -38.78% ============================================ Files 16 184 +168 Lines 1410 8136 +6726 Branches 0 1415 +1415 ============================================ + Hits 905 2067 +1162 - Misses 465 5948 +5483 - Partials 40 121 +81 ``` | [Flag](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [cannon-go-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `62.56% <ø> (-1.63%)` | :arrow_down: | | [chain-mon-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `27.14% <ø> (?)` | | | [common-ts-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `26.72% <ø> (?)` | | | [contracts-bedrock-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `0.49% <ø> (∅)` | | | [contracts-ts-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `12.25% <ø> (?)` | | | [core-utils-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `44.03% <ø> (?)` | | | [sdk-next-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `41.53% <ø> (?)` | | | [sdk-tests](https://app.codecov.io/gh/celo-org/optimism/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `41.53% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [...ages/contracts-bedrock/src/L1/L1StandardBridge.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL0wxL0wxU3RhbmRhcmRCcmlkZ2Uuc29s) | `0.00% <ø> (ø)` | | | [...ages/contracts-bedrock/src/L2/L2StandardBridge.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL0wyL0wyU3RhbmRhcmRCcmlkZ2Uuc29s) | `0.00% <ø> (ø)` | | | [...ckages/contracts-bedrock/src/celo/CeloRegistry.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vQ2Vsb1JlZ2lzdHJ5LnNvbA==) | `0.00% <ø> (ø)` | | | [...ontracts-bedrock/src/celo/FeeCurrencyWhitelist.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vRmVlQ3VycmVuY3lXaGl0ZWxpc3Quc29s) | `0.00% <ø> (ø)` | | | [packages/contracts-bedrock/src/celo/FeeHandler.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vRmVlSGFuZGxlci5zb2w=) | `0.00% <ø> (ø)` | | | [...es/contracts-bedrock/src/celo/FeeHandlerSeller.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vRmVlSGFuZGxlclNlbGxlci5zb2w=) | `0.00% <ø> (ø)` | | | [packages/contracts-bedrock/src/celo/GoldToken.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vR29sZFRva2VuLnNvbA==) | `0.00% <ø> (ø)` | | | [...ntracts-bedrock/src/celo/MentoFeeHandlerSeller.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vTWVudG9GZWVIYW5kbGVyU2VsbGVyLnNvbA==) | `0.00% <ø> (ø)` | | | [...racts-bedrock/src/celo/UniswapFeeHandlerSeller.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vVW5pc3dhcEZlZUhhbmRsZXJTZWxsZXIuc29s) | `0.00% <ø> (ø)` | | | [...kages/contracts-bedrock/src/celo/UsingRegistry.sol](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vVXNpbmdSZWdpc3RyeS5zb2w=) | `0.00% <ø> (ø)` | | | ... and [10 more](https://app.codecov.io/gh/celo-org/optimism/pull/100?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | | ... and [151 files with indirect coverage changes](https://app.codecov.io/gh/celo-org/optimism/pull/100/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org)