search

celo-org / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
3 stars 3 forks source link

Add fee currency functions to MintableERC20 #112

Closed karlb closed 5 months ago

karlb commented 5 months ago

so that BridgedETH and other bridged ERC20 tokens can be used as fee currencies. I won't included testing until the FeeCurrencyDirectory is ready.

See https://github.com/celo-org/celo-blockchain-planning/issues/218, https://github.com/celo-org/celo-blockchain-planning/issues/219

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 25.37%. Comparing base (70d151f) to head (82e7a0e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## celo4 #112 +/- ## ========================================== - Coverage 25.39% 25.37% -0.03% ========================================== Files 184 185 +1 Lines 8139 8146 +7 Branches 1415 1416 +1 ========================================== Hits 2067 2067 - Misses 5951 5958 +7 Partials 121 121 ``` | [Flag](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [cannon-go-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `62.56% <ø> (ø)` | | | [chain-mon-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `27.14% <ø> (ø)` | | | [common-ts-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `26.72% <ø> (ø)` | | | [contracts-bedrock-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `0.49% <0.00%> (-0.01%)` | :arrow_down: | | [contracts-ts-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `12.25% <ø> (ø)` | | | [core-utils-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `44.03% <ø> (ø)` | | | [sdk-next-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `41.53% <ø> (ø)` | | | [sdk-tests](https://app.codecov.io/gh/celo-org/optimism/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | `41.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/celo-org/optimism/pull/112?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org) | Coverage Δ | | |---|---|---| | [...ts-bedrock/src/universal/OptimismMintableERC20.sol](https://app.codecov.io/gh/celo-org/optimism/pull/112?src=pr&el=tree&filepath=packages%2Fcontracts-bedrock%2Fsrc%2Funiversal%2FOptimismMintableERC20.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL3VuaXZlcnNhbC9PcHRpbWlzbU1pbnRhYmxlRVJDMjAuc29s) | `0.00% <ø> (ø)` | | | [...ackages/contracts-bedrock/src/celo/FeeCurrency.sol](https://app.codecov.io/gh/celo-org/optimism/pull/112?src=pr&el=tree&filepath=packages%2Fcontracts-bedrock%2Fsrc%2Fcelo%2FFeeCurrency.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celo-org#diff-cGFja2FnZXMvY29udHJhY3RzLWJlZHJvY2svc3JjL2NlbG8vRmVlQ3VycmVuY3kuc29s) | `0.00% <0.00%> (ø)` | |