search

celo-org / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
3 stars 2 forks source link

Combine Cel2 migration scripts #148

Closed alecps closed 2 weeks ago

alecps commented 3 weeks ago

This PR combines scripts written in https://github.com/celo-org/optimism/pull/121 and https://github.com/celo-org/optimism/pull/110

Closes https://github.com/celo-org/celo-blockchain-planning/issues/337.

Resolves #135 Resolves #160 Resolves #157 Resolves https://github.com/celo-org/optimism/issues/158

piersy commented 3 weeks ago

@alecps I'm a bit confused because there is also this PR open:

alecps commented 3 weeks ago

@piersy My hope was to merge that before this to keep the changes more incremental, but yea I might just close that one in favor of this unless anyone objects

piersy commented 3 weeks ago

@alecps At this point I think it would be simpler to just continue with this one, as a reviewer it's difficult for me to keep track of the suggested changes and their interactions between the two PRs.

piersy commented 2 weeks ago

Hey @alecps, the op service tests are failing. I guess related to changing the op-geth dependency but it would be good to know why!