search

celo-org / optimism

Optimism is Ethereum, scaled.
https://optimism.io
MIT License
3 stars 3 forks source link

Evaluate usage of the L1Cost fn in the txpool for filtering txs #99

Closed hbandura closed 2 months ago

hbandura commented 7 months ago

Upstream uses the function L1CostFn on txs' calldata to evaluate the l1 cost of a tx. However it does not seem to track it properly, e.g it's added to the totalcost but not removed when the tx is removed.

Understand how it should be implemented., if it's constant or not, and fix upstream's mistake (if any). If current implementation is actually ok, re-add the commented parts (double check for mistakes during different refactors on implementation of fee currency txpool)

lvpeschke commented 3 months ago

@celo-org/blockchain can you link this to an epic?

karlb commented 2 months ago

The known issues are fixed in https://github.com/celo-org/op-geth/pull/183.