celo-org / rainbowkit-celo

rainbowkit-with-celo.vercel.app
Apache License 2.0
12 stars 11 forks source link

Fix `maxFeePerGas` bug in example app #103

Closed arthurgousset closed 5 months ago

arthurgousset commented 5 months ago

Description

Fixes maxFeePerGas bug in example app by increasing from 0.0007 gwei to 5 gwei (5e9 wei).

The bug was:

fee-currency-2d720879575e6073.js:1 EstimateGasExecutionError: The fee cap (`maxFeePerGas` = 0.0007 gwei) cannot be lower than the block base fee.

Estimate Gas Arguments:
  from:                  0xcf941f3e6a147Eb62c0f978CADCeD28e30F0D446
  to:                    0x22579CA45eE22E2E16dDF72D955D6cf4c767B0eF
  value:                 0.1 A-CELO
  maxFeePerGas:          0.0007 gwei
  maxPriorityFeePerGas:  0.0007 gwei

Details: err: max fee per gas less than block base fee: address 0xcf941f3e6a147Eb62c0f978CADCeD28e30F0D446, maxFeePerGas: 700000 baseFee: 3220896870 (supplied gas 5010499)
Version: viem@1.2.9
    at _app-934dd97cff7957aa.js:1:661115
    at b (_app-934dd97cff7957aa.js:1:661142)
    at async fee-currency-2d720879575e6073.js:1:3812

Other changes

N/A

Tested

Ran app locally with yarn run dev

Related issues

N/A

Backwards compatibility

Yes, should work as before.

Documentation

N/A

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: cb52aa436fa566744d6265a6bea412d10abd6980

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rainbowkit-with-celo ✅ Ready (Inspect) Visit Preview Jan 25, 2024 3:32pm
arthurgousset commented 5 months ago

The release for this PR seems to have failed. Logged an issue to fix and release again:

arthurgousset commented 4 months ago

(for future reference) The release workflow (that failed) is used to publish the NPM package. Since this PR only modified the example app, no NPM publishing was needed. The Vercel deployment worked as expected.

Fixing https://github.com/celo-org/rainbowkit-celo/issues/106 was important to ensure future NPM releases work as expected, but didn't unblcoked the Vercel example app fix, since that was never blocked in the first place.