search

celo-org / rainbowkit-celo

rainbowkit-with-celo.vercel.app
Apache License 2.0
12 stars 11 forks source link

#114 Remove cannoli from codebase #115

Closed Zagorodnyi closed 4 months ago

Zagorodnyi commented 4 months ago

Description

Canolli network is no longer supported. This PR fixes error Attempted import error: 'celoCannoli' is not exported from 'viem/chains'

Related issues

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 07a2defaa6d57209311eb1a3843dde2f72e5caa4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

Someone is attempting to deploy a commit to the Celo Ecosystem Project Hosting Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-with-celo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:52am
arthurgousset commented 4 months ago

Just realised this PR forgot to include a changeset, but is removing Cannoli from the package. That's probably a major version bump. What do you think @aaronmgdr ?

aaronmgdr commented 4 months ago

1 yes need to have a changest.

2 idea was to keep the major of the package the same as the major for rainbowkit

arthurgousset commented 4 months ago

1 yes need to have a changest.

Sounds good, I'll open a PR to add a changeset for this. I checked to confirm the package hasn't been released yet. I presume we follow the typical "Versions PR" release flow.

2 idea was to keep the major of the package the same as the major for rainbowkit

Great point, seems like a minor bump would be more appropriate in that case. That's a break with the semver convention, but might be acceptable in these circumstances.

Interestingly viem only did a patch upgrade when I removed cannoli there:

arthurgousset commented 4 months ago

Sounds good, I'll open a PR to add a changeset for this. I checked to confirm the package hasn't been released yet. I presume we follow the typical "Versions PR" release flow.

@aaronmgdr: Unfortunately, I didn't get around to doing this before my OOO. Would you mind taking this on please? I would really appreciate that. Thanks! 🙏

It looks like the same PR was a patch change in viem: