celo-org / rainbowkit-celo

rainbowkit-with-celo.vercel.app
Apache License 2.0
12 stars 11 forks source link

Update for RainbowKit v2 #84

Closed jmrossy closed 3 months ago

jmrossy commented 5 months ago

Wagmi + Viem v2 are live. Rainbowkit has published a v2 beta to match it.

Relevant docs: https://beta.rainbowkit.com/guides/rainbowkit-wagmi-v2 https://viem.sh/docs/migration-guide#2xx-breaking-changes https://wagmi.sh/react/guides/migrate-from-v1-to-v2

jmrossy commented 5 months ago

Alternatively, it may be better to just get the wallets added to rainbowkit's official list: https://github.com/rainbow-me/rainbowkit/tree/main/packages/rainbowkit/src/wallets/walletConnectors

Viem already has celo in its chain consts so the need for this package is diminished

jmrossy commented 5 months ago

Seems to work: https://github.com/jmrossy/celo-station/blob/wagmi-v2/src/config/wallets.ts

aaronmgdr commented 5 months ago

alternatively consider deprecating package as (as @jmrossy mentioned) the need for it has diminished and there has proved to be high maintenance costs for such a small config.

arthurgousset commented 5 months ago

Made a Github Discussion about this so we can reference it when making the PR in rainbowkit, if/when we deprecate this package, and for future reference:

aaronmgdr commented 4 months ago

Ive reached out to Valora and they are keen to add valora config direct to rainbowkit.

for the other wallets terminal and ~celo wallet~ othello A confirm they actually work. and if need be make prs to rainbowkit

jmrossy commented 4 months ago

Othello Wallet doesn't support Wallet Connect anymore. It used a beta version of v2 that broke at some point and the lift to migrate it to the latest WC version is surprisingly high. It can be excluded.

aaronmgdr commented 3 months ago

closing as we will not be create a v2 config but instead ensuring all wallets that still work are in the official repo