celo-org / react-celo

Connect your react dApp to Celo
https://react-celo.vercel.app
MIT License
59 stars 43 forks source link

White space in wallets #289

Open product-matt opened 2 years ago

product-matt commented 2 years ago

Is there an existing issue for this?

Description

When integrating wallets for "connect wallet" white space is added between different wallet if not all wallets are activated.

Steps to reproduce

  1. Integrate wallets with latest version of react celo
  2. don't activate all available wallets to be displayed
  3. see white space (see screenshots)

Expected behavior

The whitespace around wallets should be equal and readjusted depending on how many wallets are integrated

Screenshot

Screenshot 2022-07-13 at 17 09 35

Screenshot 2022-07-15 at 10 12 19

No response

Where is the problem happening?

Both

Environment

Device: mac Browser: Chrome OS: macOS 12.4

What version of react-celo were you using? (This can be found in the list of wallets in the "Connect" modal)

v4.0.1 Release

What wallet were you using?

No response

What is the dApp URL? (if applicable)

No response

Additional context

No response

aaronmgdr commented 2 years ago

hmm i havent been able to repoduce this

When I disabled default wallets i just get

Screen Shot 2022-07-21 at 3 04 55 PM
product-matt commented 2 years ago

https://github.com/celo-org/react-celo/issues/289#issuecomment-1191461649

+Paweł Jakubowski @.***> here is the issue I submitted on the problem you had - any idea why Aaron cannot reproduce it?

On Thu, Jul 21, 2022 at 3:05 PM Aaron DeRuvo @.***> wrote:

hmm i havent been able to repoduce this

When I disabled default wallets i just get

[image: Screen Shot 2022-07-21 at 3 04 55 PM] https://user-images.githubusercontent.com/3814795/180220570-e442d98e-808b-4897-aed9-ab7bd2b5926c.png

— Reply to this email directly, view it on GitHub https://github.com/celo-org/react-celo/issues/289#issuecomment-1191461649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWA2S6OT5ZW4E2DHMIKXMYDVVFDK7ANCNFSM54APSJLA . You are receiving this because you authored the thread.Message ID: @.***>