celo-org / react-celo

Connect your react dApp to Celo
https://react-celo.vercel.app
MIT License
58 stars 42 forks source link

Allow celo SDK v2 or v3 for `@celo/wallet-walletconnect` #347

Closed jeanregisser closed 1 year ago

jeanregisser commented 1 year ago

I noticed @celo/wallet-walletconnect@5.0.2 pulled by @celo/react-celo@5.0.2 depends on celo SDK ^2.2.0 leading to duplicate packages in the final bundle if celo SDK v3 is already present.

"@celo/wallet-walletconnect@5.0.2":
  version "5.0.2"
  resolved "https://registry.yarnpkg.com/@celo/wallet-walletconnect/-/wallet-walletconnect-5.0.2.tgz#14d8fff7c232578977878f2ea2c552fe5df06b70"
  integrity sha512-CK6hGfYgrqC9iHAJvauofs9U3RdEqIZ16fm/95fgso0OMe1i8Gn9v/TNPpM2cuIY9/58zZshgHKqCAODzH8ukg==
  dependencies:
    "@celo/connect" "^2.2.0"
    "@celo/utils" "^2.2.0"
    "@celo/wallet-base" "^2.2.0"
    "@celo/wallet-remote" "^2.2.0"
    "@walletconnect/auth-client" "^2.0.2"
    "@walletconnect/sign-client" "^2.3.2"
    "@walletconnect/types" "^2.3.2"
    "@walletconnect/utils" "^2.3.2"
    debug "^4.3.3"
    ethereumjs-util "^7.1.3"

This applies a similar change to what was done for @celo/react-celo in https://github.com/celo-org/react-celo/pull/339

Let me know what you think.

Side note: I wonder if celo SDK dependencies should be switched to peerDependencies to make it easier for final applications to select the version they want.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-celo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 5:52PM (UTC)