search

celo-org / react-celo

Connect your react dApp to Celo
https://react-celo.vercel.app
MIT License
59 stars 43 forks source link

WCv2 Fix #356

Closed aaronmgdr closed 1 year ago

aaronmgdr commented 1 year ago

Fixes signing tx with certain wc wallets

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-celo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 6:28pm
socket-security[bot] commented 1 year ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Network access @walletconnect/core 2.7.3 package.json via @celo/wallet-walletconnect@5.0.4-beta.1, @walletconnect/sign-client@2.7.3, @walletconnect/web3wallet@1.7.1, packages/example/package.json via @celo/wallet-walletconnect@5.0.4-beta.1, @walletconnect/sign-client@2.7.3, @walletconnect/web3wallet@1.7.1, packages/react-celo/package.json via @celo/wallet-walletconnect@5.0.4-beta.1, packages/walletconnect/package.json via @walletconnect/sign-client@2.7.3

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @walletconnect/core@2.7.3
aaronmgdr commented 1 year ago

fixes https://github.com/celo-org/react-celo/issues/354

socket-security[bot] commented 1 year ago

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives^1 Size Publisher
@celo/wallet-walletconnect 🆕 5.0.4-beta.1 environment +36 18.9 MB aaron-clabs
@walletconnect/web3wallet 🆕 1.7.1 environment +26 19.5 MB gancho_walletconnect
@walletconnect/core 🆕 2.7.3 network, environment +30 10.3 MB gancho_walletconnect
@walletconnect/sign-client ⬆️ 2.1.4...2.7.3 environment +33/-22 15.6 MB gancho_walletconnect
@walletconnect/utils ⬆️ 2.1.4...2.7.3 None +21/-14 5.08 MB gancho_walletconnect
@walletconnect/types ⬆️ 2.3.2...2.7.3 None +3/-6 1.02 MB gancho_walletconnect

🚮 Removed packages: @walletconnect/auth-client@2.0.2