search

celo-org / react-celo

Connect your react dApp to Celo
https://react-celo.vercel.app
MIT License
59 stars 43 forks source link

imToken #67

Closed patricknbaron closed 2 years ago

patricknbaron commented 2 years ago

When connected via imToken wallet, the provider shows as 'MetaMask'

IMG_A6CEB1DED6B3-1

aslawson commented 2 years ago

@patricknbaron @dckesler did we add imToken as a wallet option? I'm assuming this is through the user clicking the generic "WalletConnect" option. We'll be pulling the wallet details from the central WalletConnect repo and limiting to those that specify they work with the Celo network Id, so that repo should have the wallet config details.

patricknbaron commented 2 years ago

It does not use WalletConnect because WC still does not work on Celo. Ubeswap added imToken as a wallet option that opens in the imToken dapp browser. Please try app.moola.market on your mobile device to see what I'm talking about: https://github.com/Ubeswap/use-contractkit/blob/master/packages/use-contractkit/src/connectors/connectors.ts

dckesler commented 2 years ago

So this was on Ubeswap's fork of use-contractkit so I can't speak specifically to this issue. However, we did add something to not show "MetaMask" unless we're sure that's what it is. Otherwise it will have a generic message of "Injected"