search

celo-org / safe-react

Celo Safe – A platform to store digital assets on Celo (base on Gnosis Safe)
safe-react-beta.vercel.app
MIT License
6 stars 4 forks source link

Merge proxy & implementation contract ABIs #39

Closed douglasqian closed 2 years ago

douglasqian commented 2 years ago

What it solves

Today it is hard to interact with proxy contracts on Celo Safe because only the proxy contract ABI is loaded from Blockscout.

See #37

How this PR solves it

This PR performs a simple check for each address provided in the "contract interaction" modal flow by querying for an implementation contract address in the implementation slot designed in EIP-1967. If the address exists, then we attempt to fetch that ABI and merge it with the proxy contract ABI (this is very similar to what Blockscout does)

How to test it

Try the "contract interaction" flow with a proxy contract address. Should be able to execute transaction on methods on the implementation contract ABI.

Screenshots

Screen Shot 2022-07-26 at 4 44 46 PM
vercel[bot] commented 2 years ago

@douglasqian is attempting to deploy a commit to the cLabs Team on Vercel.

A member of the Team first needs to authorize it.

douglasqian commented 2 years ago

PTAL @dckesler @nicolasbrugneaux @aaronmgdr 🙏

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
safe-react ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 3:25PM (UTC)