Closed alvarof2 closed 10 months ago
Latest commit: d4062a9b00ae42c07e1164ac4a8e80821ce9685e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Description
Removes
@opentelemetry
dependencies from common package.Other changes
N/A
Tested
Then, locally:
package.json
for@celo/phone-number-privacy-common
.package.json
for@celo/phone-number-privacy-signer
and@celo/phone-number-privacy-common
dependency.package.json
for@celo/phone-number-privacy-combiner
and@celo/phone-number-privacy-common
dependency.yarn start:docker:tracing
and env. vars.export TRACING_SERVICE_NAME=alvaro-test-combiner
andexport TRACER_ENDPOINT=http://localhost:14268/api/traces
yarn start:docker:tracing
and env. vars.export TRACING_SERVICE_NAME=alvaro-test-signer
andexport TRACER_ENDPOINT=http://localhost:14268/api/traces
curl localhost:8080/status
andcurl localhost:8081/status
.Got these traces:
Combiner: https://clabs.grafana.net/goto/MARfSJcSR?orgId=1
Signer: https://clabs.grafana.net/goto/6SLAIJcSR?orgId=1
Related issues
Backwards compatibility
N/A
Documentation
N/A