Verify SocialConnect ready for Alfajores L2 Migration

alecps commented 6 months ago

SocialConnect should keep working almost transparently.

### Tasks
- [ ] https://github.com/celo-org/social-connect/issues/289
- [ ] https://github.com/celo-org/celo-blockchain-planning/issues/267
- [ ] https://github.com/celo-org/social-connect/issues/282
- [ ] https://github.com/celo-org/social-connect/issues/284
- [ ] https://github.com/celo-org/social-connect/issues/286
- [ ] https://github.com/celo-org/celo-blockchain-planning/issues/203
- [ ] https://github.com/celo-org/celo-blockchain-planning/issues/204

mcortesi commented 4 months ago

@alecps @soloseng

Can you please take a look at the tasks?

My understanding is that there's nothing to do for Alfajores L2. There's only 2 things i imagine make sense:

Do a quick test of using ODIS pointing to Danjo, to just check it works. Should basically be the same that checks alfajores but pointin to danjo RPC
Double check contracts to see if there's something to change. Or document.

What i see is too many tasks that makes it unclear what this really is.

Am i mistaken?

Also if there are thing that needs to be post-deployment, let's create another isseu for that

alecps commented 4 months ago

I agree with @mcortesi , I didn't write most of the original tasks and am not sure I understand all of them (update: I removed these tickets from the epic). ODIS depends on Forno, so this is really just a task to make sure Forno transitions to the L2 full node cleanly at migration time.

Ideally, services relying on forno should be able to keep the same URL, and forno will switch to the L2 network when the migration happens so ODIS will not need to do anything
State will be migrated to the L2, so we don't need to check that contracts are migrated
No one uses Alfajores ODIS, so we can test this during the alfajores migration

Nothing changes for ODIS as a result of the L2 migration except for the full node it talks to

If 'https://forno.celo.org/' is redirected to an L2 full node, and signers all rely on forno (which we can verify, added a ticket for this) then SocialConnect should work with Cel2 automatically

Of course, we'll want to test that ODIS and the SocialConnect contracts work on Dango and make sure MiniPay tests their setup e2e on a testnet as well. I added tickets for this.

alecps commented 4 months ago

@lvpeschke I've removed all the extraneuous tasks from this epic. I'm not sure about the contractkit one. @soloseng can you add context there?

lvpeschke commented 2 months ago

Hey all, could the tests on Dango happen ASAP to uncover any potential issues ASAP and decide how to tackle them, if any? @alecps @martinvol @soloseng

alecps commented 2 months ago

@lvpeschke for the tests to happen we need to point Alfajores ODIS to Dango (I can ask devops for this) and then just run our existing e2e tests against that instance.

This will cover

There are some other tickets here that I don't understand

lvpeschke commented 2 months ago

@martinvol do you have more context about the above?

soloseng commented 2 months ago

adding discussion thread regarding this issue

https://clabsco.slack.com/archives/CP5V8KF51/p1726158289642649

martinvol commented 2 months ago

Pasting Alec update here

celo-org / social-connect

Verify SocialConnect ready for Alfajores L2 Migration #280