Test cleanup: `before`, snapshots, multisig and validator utils - Githubissues

celo-org / staked-celo

GNU Lesser General Public License v3.0

8 stars 2 forks source link

Test cleanup: `before`, snapshots, multisig and validator utils #193

Closed m-chrzan closed 3 months ago

m-chrzan commented 3 months ago

Description

Started doing some cleanup on the unit tests.

There were inconsistencies in the use of before, beforeEach, and snapshots.
- Now all unit test suites do all their top-level setup in a before
- and use hardhat snapshots (in before/afterEach) to reset between unit tests.
the test-ts/utils.ts file has become a monolith, started splitting it up into domain-specific files.

Other changes

Removed getIndexesOfElectedValidatorGroupMembers, an unused function.

Tested

Unit tests should still be passing.