search

celo-org / staked-celo

GNU Lesser General Public License v3.0
8 stars 2 forks source link

Proxy deploy tests + e2e test #60

Closed pahor167 closed 2 years ago

pahor167 commented 2 years ago

Description

Extended deployment tests

Other changes

Tested

Hardhat tests

Related issues

pahor167 commented 2 years ago

Looks good! Just a few unused vars from refactoring.

One thing I'm not sure about. In your previous conversations with @m-chrzan, he mentioned using "real deployments rather than test fixtures". Not sure if that meant using contracts deployed on alfajores or mainnet, but It looks like we are still using fixtures for the proxy-deploy.test.ts test.

It was not about using deployed contracts, but rather using fixture that is not mocked for test purpose. Please check deploy/test folder vs just deploy folder. The reason why we have test fixtures is not to have to use eg Multisig proposals and so on. Currently both e2e and proxy-deploy test is using standard fixtures.