search

celo-org / staked-celo

GNU Lesser General Public License v3.0
8 stars 2 forks source link

Enable voting for specific validator group #88

Closed pahor167 closed 1 year ago

pahor167 commented 1 year ago

Description

PR introduces ability to vote for specific validator rather than default strategy.

Other changes

We will have to update also our bot to accommodate transfers.

Tested

There are multiple tests in this PR

Related issues

pahor167 commented 1 year ago

Reviewed contract changes and some of the tests.

General question, why are we no longer transferring votes on deposit when group specific strategy group is invalid?

We are transferring it to default strategy, but specific strategy is taking care of it now. The problem with previous approach was that we SpecificStrategy didn't keep accounting of stCELO moved to default strategy and thus we were not able to move it back when specific strategy became healthy again. Now since specific strategy is taking care of it, it also keeps track of accounting and we are able to move stCELO back from DefaultStrategy when specific group is healthy a not blocked