celo-org / staked-celo

GNU Lesser General Public License v3.0
8 stars 2 forks source link

Upgrade contracts on alfajores. #90

Closed montera82 closed 1 year ago

montera82 commented 1 year ago

Description

Upgrade contracts on alfajores. This work only successfully deploys the contract on alfajores. It works but was quite manual and error prone, a better way will be to invest some time to come up with a runbook. Potentially a one line command.

Other changes

Describe any minor or "drive-by" changes here. A few changes to the deployment and docs.

Related issues

socket-security[bot] commented 1 year ago

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
@trufflesuite/bigint-buffer@1.1.10 (added) binding.gyp
classic-level@1.2.0 (added) binding.gyp yarn.lock via @ethereumjs/blockchain@6.0.2, level@8.0.0
@trufflesuite/bigint-buffer@1.1.10 (added) install
classic-level@1.2.0 (added) install yarn.lock via @ethereumjs/blockchain@6.0.2, level@8.0.0
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Package Location Source
@trufflesuite/bigint-buffer@1.1.10 (added) binding.gyp
classic-level@1.2.0 (added) binding.gyp yarn.lock via @ethereumjs/blockchain@6.0.2, level@8.0.0
😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
@ethereumjs/rlp@4.0.0 (added) rlp yarn.lock
rlp@2.2.6 (upgraded) rlp yarn.lock
Pull request report summary
Issue Status
Install scripts ⚠️ 4 issues
Native code ⚠️ 2 issues
Bin script confusion ⚠️ 2 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore @trufflesuite/bigint-buffer@1.1.10
  • @SocketSecurity ignore classic-level@1.2.0
  • @SocketSecurity ignore @ethereumjs/rlp@4.0.0
  • @SocketSecurity ignore rlp@2.2.6

Powered by socket.dev

montera82 commented 1 year ago

not sure how much of an issue this is, but the deployments/alfajores/stackedCelo.json was not updated. It still shows the implementation address as the old cntract address.

this is done. Mind looking again?