search

celo-org / viem

TypeScript Interface for Ethereum
https://viem.sh
Other
0 stars 0 forks source link

Feature/celo cip 64 support #3

Closed yerdua closed 11 months ago

aaronmgdr commented 1 year ago

apart from the ordering comments looking good

github-actions[bot] commented 11 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 58.13 KB (0%) 1.2 s (0%) 2.6 s (+17.08% 🔺) 3.8 s
viem (cjs) 76.9 KB (0%) 1.6 s (0%) 3.1 s (-11.48% 🔽) 4.6 s
viem (minimal surface - tree-shaking) 3.86 KB (0%) 78 ms (0%) 640 ms (+55% 🔺) 717 ms
viem/accounts 89.01 KB (0%) 1.8 s (0%) 1.6 s (-27.3% 🔽) 3.4 s
viem/accounts (tree-shaking) 19.37 KB (0%) 388 ms (0%) 853 ms (+0.13% 🔺) 1.3 s
viem/actions 43.25 KB (0%) 865 ms (0%) 12.5 s (+18.4% 🔺) 13.4 s
viem/actions (tree-shaking) 350 B (0%) 10 ms (0%) 512 ms (-24.41% 🔽) 522 ms
viem/chains 17.29 KB (+1.26% 🔺) 346 ms (+1.26% 🔺) 1.2 s (+5.36% 🔺) 1.5 s
viem/chains (tree-shaking) 470 B (0%) 10 ms (0%) 455 ms (-38.94% 🔽) 465 ms
viem/chains/utils 8.29 KB (+3.96% 🔺) 166 ms (+3.96% 🔺) 745 ms (+27.99% 🔺) 911 ms
viem/chains/utils (tree-shaking) 5.36 KB (+2.3% 🔺) 108 ms (+2.3% 🔺) 637 ms (+12.74% 🔺) 744 ms
viem/ens 43.25 KB (0%) 865 ms (0%) 9.7 s (-32.59% 🔽) 10.6 s
viem/ens (tree-shaking) 17.94 KB (0%) 359 ms (0%) 1.4 s (-9.95% 🔽) 1.7 s
jxom commented 11 months ago

Would love to see this PR'd upstream into Viem!

yerdua commented 11 months ago

Would love to see this PR'd upstream into Viem!

Thanks for the encouragement! PR for upstream is here: https://github.com/wagmi-dev/viem/pull/1379

aaronmgdr commented 11 months ago

closing in favor of https://github.com/wagmi-dev/viem/pull/1379