Distant Horizon's distant generation cause towers to generate without top

[johalun]

Just like the title says. When Distant Horizons generate the LODs for a chunk that has a tower, before a player or a chunk generator has generated the chunks, towers are likely (or always?) to generate without the top. If I disable DH distant generation and use chunky instead, the towers are intact.

I don't know if this is a DH or TOTW issue but thought I'd post here anyways.

[Ethan-C-Honzik]

I get multi-threading errors in the terminal when running this mod, its doing some custom world gen that likely isn't thread safe

[johalun]

My understanding is that it generates the chunks in order to generate the LOD data, but then discards the chunk data. It's not clear to me why this would cause any issues when the same chunk is later generated again by the player.

[Ethan-C-Honzik]

The dh world generator is separate from the vanilla one. It uses the vanilla world gen code but heavily multi threaded. This means dh can break specific mods that don't exptect the world to be generated like this. The feature generation happens as a separate step. If there's an exception while generating then the specific features just aren't generated.

[johalun]

Thanks for clarifying. But if it's the case that features/chunks generated by DH are discarded after the LODs are built, it still doesn't explain why the towers are broken when later on a player (or chunky) generates the chunks.

[johalun]

Just to clarify, I don't care much if the DH LODs show the towers without top, what I care about is that they actually generate with a top when the player is within vanilla render distance and generates the chunks (or chunky).

[Ethan-C-Honzik]

Ah I thought you just meant the lods, if it's in the actual chunks that doesn't sound like a dh issue

[johalun]

Or a combination? After DH has generated the chunks and LODs, and removed the chunk data, could there any data left in cache or something that could cause vanilla terrain gen to behave different than if DH had never generated the LODs in the first place? This is the behavior I'm seeing, DH is doing something that makes vanilla terrain gen behave differently when it generates new chunks that DH has previously generated LODs from.

[johalun]

Compare these scenarios in a fresh new world

• vanilla terrain gen generates a tower
• tower is complete, not issues

fresh new world 2

• DH generates LODs for an area with a tower in it, in new chunks outside of vanilla render distance
• DH clear all chunk data for that area as part of its LOD generation process
• vanilla terrain gen generates a tower
• tower is broken, top is missing

[johalun]

I found a tower that always generates without top without DH even being in the pack so it seems it happens regardless, although more rare.

MC 1.20.1 Forge Tectonic + Terralith

We have changed tower spawn biomes and frequency so it's no point giving the location since you'd have to duplicate all the customization. Also, derelict towers are disabled with kubejs.

[efficient-efi]

I encountered the same problem. Even after turning off chunk generation in the DH, the top of the tower generated by running the /place structure command was missing. Uninstalling DH had the same result.

[celsiusqc]

So can someone provide a concrete description of the issue for me to tackle? Mod Version: Minecraft Version: Mods Used: Problem Encountered: Game Seed: Coordinates of Structure

[crbd115]

So I was having this issue before as well and was following this while I tried to find solutions. The most recent DH update that came out today seems to have solved this? I installed the new version, and turned off chunk generating to test. I currently generating new worlds and testing but I used to have this issue all the time and now I haven't seen one.

edit: ok found one, and it seemed to be because I was stressing the chunk generation a bit

[SettingDust]

https://github.com/celsiusqc/TowersOfTheWildModded/issues/17#issuecomment-2191305831