celsiusqc / TowersOfTheWildModded

0 stars 2 forks source link

Custom waystone names aren't applied #3

Closed Kelpiesaurus closed 3 months ago

Kelpiesaurus commented 11 months ago

Hello,

I have 200 custom names in the Waystones config, and they generate fine with regular waystones in villages & elsewhere, but waystones at the top of towers do not get assigned a name from the list. When I right-click on them, the runes light up but the label continues to say "Undiscovered." I have attached before & after pics below.

TowersWildWaystoneUndiscovered TowersWildWaystoneDiscovered

Also, they show up as "unnamed" in the GUI: TowersWildWaystoneUnnamed

celsiusqc commented 11 months ago

Hi, Could you test to see if this happens with all variants?

If so, it would be the way I made the waystones generate with the structure. They require players to rename them in that case.

Also, please let me know which version of the mod you are using and which version of minecraft

celsiusqc commented 11 months ago

It seems to be occurring on other variants. I will have to run some tests on my end to try and fix, but frankly it is not a top priority of mine since waystones can easily be renamed by players.

ZEROX7 commented 10 months ago

the issue also happens if none custom names are provided, in my case the player are not allowed to rename them, wich kinda sucks for them. EDIT: it also prevents JMI to work correctly no marked is placed

celsiusqc commented 10 months ago

I am currently working on trying to get this fixed

SigmaFlame commented 6 months ago

They really need be generated with random names. Or at least the dimension name and coordinate should be fine as well.

Your mod would be perfect but it is sadly incompatible with the fact we want waystones being unable to be moved by players.

celsiusqc commented 6 months ago

The waystones not being breakable should work. I have it working for my own modpack with my own mod. Please test about your configs. My modpack Create Planetary has it working. For the random names, I tried fixing it over the summer but ran into difficulties. I tried getting help from the Waystones mod author, but his advice did not work. Feel free to test it out, contact them, make a pull request and we can try and get it fixed.

SigmaFlame commented 6 months ago

Waystones generated by Waystones itself are unbreakable. (the ones in villages and in the wild) But ... Waystones generated by your mod (in the top of a tower) are still breakable. Your mod ignore the setting of "generatedWaystonesUnbreakable"

There is another way to make them all unbreakable and that's work with your mod, the setting "restrictToCreative" But, this setting prevent waystones to be renamed by players and as your waystones does not have a name, it's very problematic

celsiusqc commented 5 months ago

Are you sure? I believe I had this working in 1.20.1 version with the waystones being unbreakable and you being able to rename them. I'll try and test this out in the next few days and find a fix if so

AikaBack commented 5 months ago

this issue with unnamed towers is still on 1.20.1 mod version totw_modded-1.0.2-1.20.1

AikaBack commented 5 months ago

aand its still breakable with unbreakable config

celsiusqc commented 4 months ago

Unnamed issue is still on-going, I am attempting to get help from the Waystones mod creator, as the issue seems to be coming from their end. New version will be releasing, but it only adds a Aether tower, and does not fix the issue.

Also, I checked, configs for only allowing creative players to break towers / unbreakable if naturally generated, the configs work as intended

celsiusqc commented 3 months ago

Found the fix for the waystones generating names on world gen and making the unbreakable config be respected. I will be updating all structure files and updating the versions accordingly. Fixes should be up soon